FONcArray.cc

// FONcArray.cc
 
// This file is part of BES Netcdf File Out Module
 
// Copyright (c) 2004,2005 University Corporation for Atmospheric Research
// Author: Patrick West <pwest@ucar.edu> and Jose Garcia <jgarcia@ucar.edu>
//
// This library is free software; you can redistribute it and/or
// modify it under the terms of the GNU Lesser General Public
// License as published by the Free Software Foundation; either
// version 2.1 of the License, or (at your option) any later version.
//
// This library is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
// Lesser General Public License for more details.
//
// You should have received a copy of the GNU Lesser General Public
// License along with this library; if not, write to the Free Software
// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
//
// You can contact University Corporation for Atmospheric Research at
// 3080 Center Green Drive, Boulder, CO 80301
 
// (c) COPYRIGHT University Corporation for Atmospheric Research 2004-2005
// Please read the full copyright statement in the file COPYRIGHT_UCAR.
//
// Authors:
//      pwest       Patrick West <pwest@ucar.edu>
//      jgarcia     Jose Garcia <jgarcia@ucar.edu>
//      Kent Yang <myang6@hdfgroup.org> (for DAP4/netCDF-4 enhancement)
 
#include <sstream>
#include <algorithm>
 
#include <libdap/Array.h>
 
#include <BESInternalError.h>
#include <BESSyntaxUserError.h>
#include <BESDebug.h>
 
#include "FONcRequestHandler.h" // For access to the handler's keys
#include "FONcArray.h"
#include "FONcDim.h"
#include "FONcGrid.h"
#include "FONcMap.h"
#include "FONcUtils.h"
#include "FONcAttributes.h"
 
using namespace libdap;
 
// This controls whether variables' data values are deleted as soon
// as they are written (except for DAP2 Grid Maps, which may be shared).
#define CLEAR_LOCAL_DATA 1
 
vector<FONcDim *> FONcArray::Dimensions;
 
const int MAX_CHUNK_SIZE = 1024;
 
FONcArray::FONcArray(BaseType *b) :
        FONcBaseType(), d_a(0), d_array_type(NC_NAT), d_ndims(0), d_actual_ndims(0), d_nelements(1), d4_dim_ids(0),
        d_dim_ids(0), d_dim_sizes(0), /* FIXME d_str_data(0),*/ d_dont_use_it(false), d_chunksizes(0),
        d_grid_maps(0), d4_def_dim(false) {
    d_a = dynamic_cast<Array *>(b);
    if (!d_a) {
        string s = "File out netcdf, FONcArray was passed a variable that is not a DAP Array";
        throw BESInternalError(s, __FILE__, __LINE__);
    }
 
    for (unsigned int i = 0; i < d_a->dimensions(); i++)
        use_d4_dim_ids.push_back(false);
}
 
FONcArray::FONcArray(BaseType *b, const vector<int> &fd4_dim_ids, const vector<bool> &fuse_d4_dim_ids,
                     const vector<int> &rds_nums) :
        FONcBaseType(), d_a(0), d_array_type(NC_NAT), d_ndims(0), d_actual_ndims(0), d_nelements(1), d_dim_ids(0),
        d_dim_sizes(0), /* FIXME d_str_data(0),*/ d_dont_use_it(false), d_chunksizes(0), d_grid_maps(0) {
    d_a = dynamic_cast<Array *>(b);
    if (!d_a) {
        string s = "File out netcdf, FONcArray was passed a variable that is not a DAP Array";
        throw BESInternalError(s, __FILE__, __LINE__);
    }
    if (d_a->is_dap4()) {
        BESDEBUG("fonc", "FONcArray() - constructor is dap4 " << endl);
        d4_dim_ids = fd4_dim_ids;
        use_d4_dim_ids = fuse_d4_dim_ids;
        d4_def_dim = true;
        d4_rds_nums = rds_nums;
    }
}
 
FONcArray::~FONcArray() {
    // Added jhrg 8/28/13
    vector<FONcDim *>::iterator d = d_dims.begin();
    while (d != d_dims.end()) {
        (*d)->decref();
        ++d;
    }
 
    // Added jhrg 8/28/13
    vector<FONcMap *>::iterator i = d_grid_maps.begin();
    while (i != d_grid_maps.end()) {
        (*i)->decref();
        ++i;
    }
}
 
void FONcArray::convert(vector<string> embed, bool _dap4, bool is_dap4_group) {
    FONcBaseType::convert(embed, _dap4, is_dap4_group);
 
    _varname = FONcUtils::gen_name(embed, _varname, _orig_varname);
 
    BESDEBUG("fonc", "FONcArray::convert() - converting array " << _varname << endl);
 
    d_array_type = FONcUtils::get_nc_type(d_a->var(), isNetCDF4_ENHANCED());
 
    if(d_array_type == NC_NAT) {
 
        string err = "fileout_netcdf: The datatype of this variable '" + _varname;
        err += "' is not supported. It is very possible that you try to obtain ";
        err += "a netCDF file that follows the netCDF classic model. ";
        err += "The unsigned 32-bit integer and signed/unsigned 64-bit integer ";
        err += "are not supported by the netCDF classic model. Downloading this file as the netCDF-4 file that ";
        err += "follows the netCDF enhanced model should solve the problem.";
 
        throw BESInternalError(err, __FILE__, __LINE__);
    }
 
#if !NDEBUG
    if (d4_dim_ids.size() > 0) {
        BESDEBUG("fonc", "FONcArray::convert() - d4_dim_ids size is " << d4_dim_ids.size() << endl);
    }
#endif
 
    d_ndims = d_a->dimensions();
    d_actual_ndims = d_ndims; //replace this with _a->dimensions(); below TODO
    if (d_array_type == NC_CHAR) {
        // if we have an array of strings then we need to add the string length
        // dimension, so add one more to ndims
        d_ndims++;
    }
 
    // See HYRAX-805. When assigning values using [], set the size using resize
    // not reserve. THe reserve method works to optimize push_back(), but apparently
    // does not work with []. jhrg 8/3/18
    d_dim_ids.resize(d_ndims);
    d_dim_sizes.resize(d_ndims);
 
    Array::Dim_iter di = d_a->dim_begin();
    Array::Dim_iter de = d_a->dim_end();
    int dimnum = 0;
    for (; di != de; di++) {
        int size = d_a->dimension_size(di, true);
        d_dim_sizes[dimnum] = size;
        d_nelements *= size;
 
        // Set COMPRESSION CHUNK SIZE for each dimension.
        d_chunksizes.push_back(size <= MAX_CHUNK_SIZE ? size : MAX_CHUNK_SIZE);
 
        BESDEBUG("fonc", "FONcArray::convert() - dim num: " << dimnum << ", dim size: " << size << ", chunk size: "
                                                            << d_chunksizes[dimnum] << endl);
        BESDEBUG("fonc", "FONcArray::convert() - dim name: " << d_a->dimension_name(di) << endl);
 
        // If this dimension is a D4 dimension defined in its group, just obtain the dimension ID.
        if (true == d4_def_dim && use_d4_dim_ids[dimnum] == true) {
            d_dim_ids[dimnum] = d4_dim_ids[dimnum];
            BESDEBUG("fonc", "FONcArray::convert() - has dap4 group" << endl);
 
        }
        else {
            // See if this dimension has already been defined. If it has the
            // same name and same size as another dimension, then it is a
            // shared dimension. Create it only once and share the FONcDim
            int ds_num = FONcDim::DimNameNum + 1;
            while (find(d4_rds_nums.begin(), d4_rds_nums.end(), ds_num) != d4_rds_nums.end()) {
            // Note: the following #if 0 #endif block is only for future development.
            //       Don't delete or change it for debuggging. 
#if 0
                // This may be an optimization for rare cases. May do this when performance issue hurts
                //d4_rds_nums_visited.push_back(ds_num);
#endif
                // Now the following line ensure this dimension name dimds_num(ds_num is a number)
                // is NOT created for the dimension that doesn't have a name in DAP4.
                ds_num++;
            }
            FONcDim::DimNameNum = ds_num - 1;
 
            FONcDim *use_dim = find_dim(embed, d_a->dimension_name(di), size);
            d_dims.push_back(use_dim);
        }
 
        dimnum++;
    }
 
    // if this array is a string array, then add the length dimension
    if (d_array_type == NC_CHAR) {
        // Calling intern_data() here is part of the 'streaming' refactoring.
        // For the other types, the call can go in the write() implementations,
        // but because strings in netCDF are arrays of char, a string array
        // must have an added dimension (so a 1d string array becomes a 2d char
        // array). To build the netCDF file, we need to know the dimensions of
        // the array when the file is defined, not when the data are written.
        // To know the size of the extra dimension used to hold the chars, we
        // need to look at all the strings and find the biggest one. Thus, in
        // order to define the variable for the netCDF file, we need to read
        // string data long before we actually write it out. Kind of a drag,
        // but not the end of the world. jhrg 5/18/21
        if (is_dap4)
            d_a->intern_data();
        else
            d_a->intern_data(*get_eval(), *get_dds());
 
        // get the data from the dap array
        int array_length = d_a->length();
#if 0
        d_str_data.reserve(array_length);
        d_a->value(d_str_data);
 
        // determine the max length of the strings
        size_t max_length = 0;
        for (int i = 0; i < array_length; i++) {
            if (d_str_data[i].length() > max_length) {
                max_length = d_str_data[i].length();
            }
        }
        max_length++;
#endif
        size_t max_length = 0;
        for (int i = 0; i < array_length; i++) {
            if (d_a->get_str()[i].length() > max_length) {
                max_length = d_a->get_str()[i].length();
            }
        }
        max_length++;
 
        vector<string> empty_embed;
        string lendim_name;
        if (is_dap4_group == true) {
            // Here is a quick implementation. 
            // We just append the DimNameNum(globally defined)
            // and then increase the number by 1.
            ostringstream dim_suffix_strm;
            dim_suffix_strm << "_len" << FONcDim::DimNameNum + 1;
            FONcDim::DimNameNum++;
            lendim_name = _varname + dim_suffix_strm.str();
 
        }
        else
            lendim_name = _varname + "_len";
 
 
        FONcDim *use_dim = find_dim(empty_embed, lendim_name, max_length, true);
        // Added static_cast to suppress warning. 12.27.2011 jhrg
        if (use_dim->size() < static_cast<int>(max_length)) {
            use_dim->update_size(max_length);
        }
 
        d_dim_sizes[d_ndims - 1] = use_dim->size();
        d_dim_ids[d_ndims - 1] = use_dim->dimid();
 
        //DAP4 dimension ID is false.
        use_d4_dim_ids.push_back(false);
        d_dims.push_back(use_dim);
 
        // Adding this fixes the bug reported by GSFC where arrays of strings
        // caused the handler to throw an error stating that 'Bad chunk sizes'
        // were used. When the dimension of the string array was extended (because
        // strings become char arrays in netcdf3/4), the numbers of dimensions
        // in 'chunksizes' was not bumped up. The code below in convert() that
        // set the chunk sizes then tried to access data that had never been set.
        // jhrg 11/25/15
        d_chunksizes.push_back(max_length <= MAX_CHUNK_SIZE ? max_length : MAX_CHUNK_SIZE);
    }
 
    // If this array has a single dimension, and the name of the array
    // and the name of that dimension are the same, then this array
    // might be used as a map for a grid defined elsewhere.
    // Notice: DAP4 doesn't have Grid and the d_dont_use_it=true causes some
    // variables not written to the  netCDF-4 file with group hierarchy.
    // So need to have the if check. KY 2021-06-21
    if(is_dap4 == false) {
        if (!FONcGrid::InGrid && d_actual_ndims == 1 && d_a->name() == d_a->dimension_name(d_a->dim_begin())) {
            // is it already in there?
            FONcMap *map = FONcGrid::InMaps(d_a);
            if (!map) {
                // This memory is/was leaked. jhrg 8/28/13
                FONcMap *new_map = new FONcMap(this);
                d_grid_maps.push_back(new_map);        // save it here so we can free it later. jhrg 8/28/13
                FONcGrid::Maps.push_back(new_map);
            }
            else {
                d_dont_use_it = true;
            }
        }
    }
 
    BESDEBUG("fonc", "FONcArray::convert() - done converting array " << _varname << endl);
}
 
FONcDim *
FONcArray::find_dim(vector<string> &embed, const string &name, int size, bool ignore_size) {
    string oname;
    string ename = FONcUtils::gen_name(embed, name, oname);
    FONcDim *ret_dim = 0;
    vector<FONcDim *>::iterator i = FONcArray::Dimensions.begin();
    vector<FONcDim *>::iterator e = FONcArray::Dimensions.end();
    for (; i != e && !ret_dim; i++) {
        if (!((*i)->name().empty()) && ((*i)->name() == name)) {
            if (ignore_size) {
                ret_dim = (*i);
            }
            else if ((*i)->size() == size) {
                ret_dim = (*i);
            }
            else {
                if (embed.size() > 0) {
                    vector<string> tmp;
                    return find_dim(tmp, ename, size);
                }
                string err = "fileout_netcdf: dimension found with the same name, but different size";
                throw BESInternalError(err, __FILE__, __LINE__);
            }
        }
    }
    if (!ret_dim) {
        ret_dim = new FONcDim(name, size);
        FONcArray::Dimensions.push_back(ret_dim);
    }
    else {
        ret_dim->incref();
    }
    return ret_dim;
}
 
void FONcArray::define(int ncid) {
    BESDEBUG("fonc", "FONcArray::define() - defining array '" << _varname << "'" << endl);
 
    if (!_defined && !d_dont_use_it) {
 
        BESDEBUG("fonc", "FONcArray::define() - defining array ' defined already: " << _varname << "'" << endl);
 
        // Note: the following #if 0 #endif block is only for future development.
        //       Don't delete or change it for debuggging. 
 
#if 0
        if(d4_dim_ids.size() >0) {
           if(d_array_type == NC_CHAR) {
               if(d_dims.size() == 1) {
                   FONcDim *fd = *(d_dims.begin());
                   fd->define(ncid);
                   d_dim_ids[d_ndims-1] = fd->dimid();
 
               }
               else {
 
               }
           }
        }
        else {
#endif
        // If not defined DAP4 dimensions(mostly DAP2 or DAP4 no groups)
        if (false == d4_def_dim) {
            vector<FONcDim *>::iterator i = d_dims.begin();
            vector<FONcDim *>::iterator e = d_dims.end();
            int dimnum = 0;
            for (; i != e; i++) {
                FONcDim *fd = *i;
                fd->define(ncid);
                //d_dim_ids.at(dimnum) = fd->dimid();
                d_dim_ids[dimnum] = fd->dimid();
                BESDEBUG("fonc", "FONcArray::define() - dim_id: " << fd->dimid() << " size:" << fd->size() << endl);
                dimnum++;
            }
        }
        else {// Maybe some dimensions are not DAP4 dimensions, will still generate those dimensions.
            int j = 0;
            for (unsigned int i = 0; i < use_d4_dim_ids.size(); i++) {
                if (use_d4_dim_ids[i] == false) {
                    FONcDim *fd = d_dims[j];
                    fd->define(ncid);
                    d_dim_ids[i] = fd->dimid();
                    j++;
                }
            }
        }
 
        int stax = nc_def_var(ncid, _varname.c_str(), d_array_type, d_ndims, d_dim_ids.data(), &_varid);
        if (stax != NC_NOERR) {
            string err = (string) "fileout.netcdf - Failed to define variable " + _varname;
            FONcUtils::handle_error(stax, err, __FILE__, __LINE__);
        }
 
        stax = nc_def_var_fill(ncid, _varid, NC_NOFILL, NULL );
        if (stax != NC_NOERR) {
            string err = (string) "fileout.netcdf - " + "Failed to clear fill value for " + _varname;
            FONcUtils::handle_error(stax, err, __FILE__, __LINE__);
        }
 
        BESDEBUG("fonc", "FONcArray::define() netcdf-4 version is " << _ncVersion << endl);
        if (isNetCDF4()) {
            BESDEBUG("fonc", "FONcArray::define() Working netcdf-4 branch " << endl);
            if (FONcRequestHandler::chunk_size == 0)
                // I have no idea if chunksizes is needed in this case.
                stax = nc_def_var_chunking(ncid, _varid, NC_CONTIGUOUS, d_chunksizes.data());
            else
                stax = nc_def_var_chunking(ncid, _varid, NC_CHUNKED, d_chunksizes.data());
 
            if (stax != NC_NOERR) {
                string err = "fileout.netcdf - Failed to define chunking for variable " + _varname;
                FONcUtils::handle_error(stax, err, __FILE__, __LINE__);
            }
 
            // TODO Make this more adaptable to the Array's data type. Find out when it's
            //  best to use shuffle, et c. jhrg 7/22/18
            if (FONcRequestHandler::use_compression) {
 
                int shuffle = 0;
                // For integer, if the type size is >= 2, turn on the shuffle key always.
                // For other types, turn off the shuffle key by default.
                if (NC_SHORT == d_array_type || NC_USHORT == d_array_type || NC_INT == d_array_type ||
                    NC_UINT == d_array_type || NC_INT64 == d_array_type || NC_UINT64 == d_array_type ||
                    FONcRequestHandler::use_shuffle)                
                    shuffle = 1;
                
                int deflate = 1;
                int deflate_level = 4;
                stax = nc_def_var_deflate(ncid, _varid, shuffle, deflate, deflate_level);
 
                if (stax != NC_NOERR) {
                    string err = (string) "fileout.netcdf - Failed to define compression (deflate) level for variable "
                                 + _varname;
                    FONcUtils::handle_error(stax, err, __FILE__, __LINE__);
                }
            }
        }
 
        // Largely revised the fillvalue check code and add the check for the DAP4 case. KY 2021-05-10
        if (is_dap4) {
            D4Attributes *d4_attrs = d_a->attributes();
            updateD4AttrType(d4_attrs, d_array_type);
        }
        else {
            AttrTable &attrs = d_a->get_attr_table();
            updateAttrType(attrs, d_array_type);
        }
 
        BESDEBUG("fonc", "FONcArray::define() - Adding attributes " << endl);
        FONcAttributes::add_variable_attributes(ncid, _varid, d_a, isNetCDF4_ENHANCED(), is_dap4);
        FONcAttributes::add_original_name(ncid, _varid, _varname, _orig_varname);
        _defined = true;
    }
    else {
        if (_defined) {
            BESDEBUG("fonc", "FONcArray::define() - variable " << _varname << " is already defined" << endl);
        }
        if (d_dont_use_it) {
            BESDEBUG("fonc", "FONcArray::define() - variable " << _varname << " is not being used" << endl);
        }
    }
 
    BESDEBUG("fonc", "FONcArray::define() - done defining array '" << _varname << "'" << endl);
}
 
void FONcArray::write_nc_variable(int ncid, nc_type var_type) {
    if (is_dap4)
        d_a->intern_data();
    else
        d_a->intern_data(*get_eval(), *get_dds());
 
    int stax;
 
    switch (var_type) {
        case NC_UBYTE:
            stax = nc_put_var_uchar(ncid, _varid, reinterpret_cast<unsigned char *>(d_a->get_buf()));
            break;
        case NC_BYTE:
            stax = nc_put_var_schar(ncid, _varid, reinterpret_cast<signed char *>(d_a->get_buf()));
            break;
        case NC_SHORT:
            stax = nc_put_var_short(ncid, _varid, reinterpret_cast<short *>(d_a->get_buf()));
            break;
        case NC_INT:
            stax = nc_put_var_int(ncid, _varid, reinterpret_cast<int *>(d_a->get_buf()));
            break;
        case NC_INT64:
            stax = nc_put_var_longlong(ncid, _varid, reinterpret_cast<long long *>(d_a->get_buf()));
            break;
        case NC_FLOAT:
            stax = nc_put_var_float(ncid, _varid, reinterpret_cast<float *>(d_a->get_buf()));
            break;
        case NC_DOUBLE:
            stax = nc_put_var_double(ncid, _varid, reinterpret_cast<double *>(d_a->get_buf()));
            break;
        case NC_USHORT:
            stax = nc_put_var_ushort(ncid, _varid, reinterpret_cast<unsigned short *>(d_a->get_buf()));
            break;
        case NC_UINT:
            stax = nc_put_var_uint(ncid, _varid, reinterpret_cast<unsigned int *>(d_a->get_buf()));
            break;
        case NC_UINT64:
            stax = nc_put_var_ulonglong(ncid, _varid, reinterpret_cast<unsigned long long *>(d_a->get_buf()));
            break;
 
        default:
            throw BESInternalError("Failed to transform array of unknown type in file out netcdf (1)",
                                         __FILE__, __LINE__);
    }
 
    if (stax != NC_NOERR) {
        string err = "fileout.netcdf - Failed to create array of " + d_a->var()->type_name() + " for " + _varname;
        FONcUtils::handle_error(stax, err, __FILE__, __LINE__);
    }
 
    // This frees the local storage. jhrg 5/14/21
#if CLEAR_LOCAL_DATA
    if (!FONcGrid::InMaps(d_a))
        d_a->clear_local_data();
#endif
}
 
void FONcArray::write(int ncid) {
    BESDEBUG("fonc", "FONcArray::write() BEGIN  var: " << _varname << "[" << d_nelements << "]" << endl);
    BESDEBUG("fonc", "FONcArray::write() BEGIN  var type: " << d_array_type << " " << endl);
 
    if (d_dont_use_it) {
        BESDEBUG("fonc", "FONcTransform::write not using variable " << _varname << endl);
        return;
    }
 
    // Writing out array is complex. There are three cases:
    // 1. Arrays of NC_CHAR, which are written the same for both the netCDF
    // classic and enhanced data models;
    // 2. All the other types, written for the enhanced data model
    // 3. All the other types, written for the classic data model
    if (d_array_type == NC_CHAR) {
        // Note that String data are not read here but in FONcArray::convert() because
        // that code needs to know that actual length of the individual strings in the
        // array. jhrg 6/4/21
 
        vector<size_t> var_count(d_ndims);
        vector<size_t> var_start(d_ndims);
        int dim = 0;
        for (dim = 0; dim < d_ndims; dim++) {
            // the count for each of the dimensions will always be 1 except
            // for the string length dimension
            var_count[dim] = 1;
 
            // the start for each of the dimensions will start at 0. We will
            // bump this up in the while loop below
            var_start[dim] = 0;
        }
 
        for (int element = 0; element < d_nelements; element++) {
            var_count[d_ndims - 1] = d_a->get_str()[element].size() + 1; // d_str_data[element].size() + 1;
            var_start[d_ndims - 1] = 0;
 
            // write out the string
            int stax = nc_put_vara_text(ncid, _varid, var_start.data(), var_count.data(), d_a->get_str()[element].c_str()); //d_str_data[element].c_str());
            if (stax != NC_NOERR) {
                string err = (string) "fileout.netcdf - Failed to create array of strings for " + _varname;
                FONcUtils::handle_error(stax, err, __FILE__, __LINE__);
            }
 
            // bump up the start.
            if (element + 1 < d_nelements) {
                bool done = false;
                dim = d_ndims - 2;
                while (!done) {
                    var_start[dim] = var_start[dim] + 1;
                    if (var_start[dim] == d_dim_sizes[dim]) {
                        var_start[dim] = 0;
                        dim--;
                    }
                    else {
                        done = true;
                    }
                }
            }
        }
 
        d_a->get_str().clear();
    }
    // If we support the netCDF-4 enhanced model, the unsigned integer
    // can be directly mapped to the netcdf-4 unsigned integer.
    else if (isNetCDF4_ENHANCED()) {
        write_for_nc4_types(ncid);
    }
    else {
        libdap::Type element_type = d_a->var()->type();
        // create array to hold data hyperslab
        switch (d_array_type) {
            case NC_BYTE:
            case NC_FLOAT:
            case NC_DOUBLE:
                write_nc_variable(ncid, d_array_type);
                break;
 
            case NC_SHORT:
                // Given Byte/UInt8 will always be unsigned they must map
                // to a NetCDF type that will support unsigned bytes.  This
                // detects the original variable was of type Byte and typecasts
                // each data value to a short.
                if (element_type == libdap::dods_byte_c || element_type == libdap::dods_uint8_c) {
                    if (is_dap4)
                        d_a->intern_data();
                    else
                        d_a->intern_data(*get_eval(), *get_dds());
 
                    // There's no practical way to get rid of the value copy, be here we
                    // read directly from libdap::Array object's memory.
                    vector<short> data(d_nelements);
                    for (int d_i = 0; d_i < d_nelements; d_i++)
                        data[d_i] = *(reinterpret_cast<unsigned char *>(d_a->get_buf()) + d_i);
 
                    int stax = nc_put_var_short(ncid, _varid, data.data());
                    if (stax != NC_NOERR) {
                        string err = (string) "fileout.netcdf - Failed to create array of shorts for " + _varname;
                        FONcUtils::handle_error(stax, err, __FILE__, __LINE__);
                    }
 
                    // Once we've written an array, reclaim its space _unless_ it is a Grid map.
                    // It might be shared and other code here expects it to be resident in memory.
                    // jhrg 6/4/21
                    if (!FONcGrid::InMaps(d_a))
                        d_a->clear_local_data();
                }
                else {
                    write_nc_variable(ncid, NC_SHORT);
                }
                break;
 
            case NC_INT:
                // Added as a stop-gap measure to alert SAs and inform users of a misconfigured server.
                // jhrg 6/15/20
                if (element_type == libdap::dods_int64_c || element_type == libdap::dods_uint64_c) {
                    // We should not be here. The server configuration is wrong since the netcdf classic
                    // model is being used (either a netCDf3 response is requested OR a netCDF4 with the
                    // classic model). Tell the user and the SA.
                    string msg;
                    if (FONcRequestHandler::classic_model == false) {
                        msg = "You asked for one or more 64-bit integer values returned using a netCDF3 file. "
                              "Try asking for netCDF4 enhanced and/or contact the server administrator.";
                    }
                    else {
                        msg = "You asked for one or more 64-bit integer values, but either returned using a netCDF3 file or "
                              "from a server that is configured to use the 'classic' netCDF data model with netCDF4. "
                              "Try netCDF4 and/or contact the server administrator.";
                    }
                    throw BESInternalError(msg, __FILE__, __LINE__);
                }
 
                if (element_type == libdap::dods_uint16_c) {
                    if (is_dap4)
                        d_a->intern_data();
                    else
                        d_a->intern_data(*get_eval(), *get_dds());
 
                    vector<int> data(d_nelements);
                    for (int d_i = 0; d_i < d_nelements; d_i++)
                        data[d_i] = *(reinterpret_cast<unsigned short *>(d_a->get_buf()) + d_i);
 
                    int stax = nc_put_var_int(ncid, _varid, data.data());
                    if (stax != NC_NOERR) {
                        string err = (string) "fileout.netcdf - Failed to create array of ints for " + _varname;
                        FONcUtils::handle_error(stax, err, __FILE__, __LINE__);
                    }
 
                    if (!FONcGrid::InMaps(d_a))
                        d_a->clear_local_data();
                }
                else {
                    write_nc_variable(ncid, NC_INT);
                }
                break;
 
            default:
                throw BESInternalError("Failed to transform array of unknown type in file out netcdf (2)",
                                       __FILE__, __LINE__);
        } // switch(d_array_type)
    }
 
    BESDEBUG("fonc", "FONcArray::write() END  var: " << _varname << "[" << d_nelements << "]" << endl);
}
 
string FONcArray::name() {
    return d_a->name();
}
 
void FONcArray::dump(ostream &strm) const {
    strm << BESIndent::LMarg << "FONcArray::dump - (" << (void *) this << ")" << endl;
    BESIndent::Indent();
    strm << BESIndent::LMarg << "name = " << _varname << endl;
    strm << BESIndent::LMarg << "ndims = " << d_ndims << endl;
    strm << BESIndent::LMarg << "actual ndims = " << d_actual_ndims << endl;
    strm << BESIndent::LMarg << "nelements = " << d_nelements << endl;
    if (d_dims.size()) {
        strm << BESIndent::LMarg << "dimensions:" << endl;
        BESIndent::Indent();
        vector<FONcDim *>::const_iterator i = d_dims.begin();
        vector<FONcDim *>::const_iterator e = d_dims.end();
        for (; i != e; i++) {
            (*i)->dump(strm);
        }
        BESIndent::UnIndent();
    }
    else {
        strm << BESIndent::LMarg << "dimensions: none" << endl;
    }
    BESIndent::UnIndent();
}
 
void FONcArray::write_for_nc4_types(int ncid) {
 
    is_dap4 = true;
 
    // create array to hold data hyperslab
    // DAP2 only supports unsigned BYTE. So here
    // we don't include NC_BYTE (the signed BYTE, the same
    // as 64-bit integer). KY 2020-03-20 
    // Actually 64-bit integer is supported.
    switch (d_array_type) {
        case NC_BYTE:
        case NC_UBYTE:
        case NC_SHORT:
        case NC_INT:
        case NC_INT64:
        case NC_FLOAT:
        case NC_DOUBLE:
        case NC_USHORT:
        case NC_UINT:
        case NC_UINT64:
            write_nc_variable(ncid, d_array_type);
            break;
 
        default:
            string err = (string) "Failed to transform array of unknown type in file out netcdf";
            throw BESInternalError(err, __FILE__, __LINE__);
    }
}